netdev - Re: [PATCH v7 bpf-next 2/3] libbpf: add support for command BPF_ENABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CFA6B73B-32FF-4CFF-A953-7CF897A36868@fb.com>
Date:   Wed, 29 Apr 2020 05:36:34 +0000
From:   Song Liu <songliubraving@...com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
CC:     bpf <bpf@...r.kernel.org>, Networking <netdev@...r.kernel.org>,
        "Alexei Starovoitov" <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "Kernel Team" <Kernel-team@...com>
Subject: Re: [PATCH v7 bpf-next 2/3] libbpf: add support for command
 BPF_ENABLE_STATS



> On Apr 28, 2020, at 10:32 PM, Andrii Nakryiko <andrii.nakryiko@...il.com> wrote:
> 
> On Tue, Apr 28, 2020 at 8:59 PM Song Liu <songliubraving@...com> wrote:
>> 
>> bpf_enable_stats() is added to enable given stats.
>> 
>> Signed-off-by: Song Liu <songliubraving@...com>
>> ---
>> tools/lib/bpf/bpf.c      | 10 ++++++++++
>> tools/lib/bpf/bpf.h      |  1 +
>> tools/lib/bpf/libbpf.map |  5 +++++
>> 3 files changed, 16 insertions(+)
>> 
>> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
>> index 5cc1b0785d18..17bb4ad06c0e 100644
>> --- a/tools/lib/bpf/bpf.c
>> +++ b/tools/lib/bpf/bpf.c
>> @@ -826,3 +826,13 @@ int bpf_task_fd_query(int pid, int fd, __u32 flags, char *buf, __u32 *buf_len,
>> 
>>        return err;
>> }
>> +
>> +int bpf_enable_stats(enum bpf_stats_type type)
>> +{
>> +       union bpf_attr attr;
>> +
>> +       memset(&attr, 0, sizeof(attr));
>> +       attr.enable_stats.type = type;
>> +
>> +       return sys_bpf(BPF_ENABLE_STATS, &attr, sizeof(attr));
>> +}
>> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
>> index 46d47afdd887..5996e64d324c 100644
>> --- a/tools/lib/bpf/bpf.h
>> +++ b/tools/lib/bpf/bpf.h
>> @@ -229,6 +229,7 @@ LIBBPF_API int bpf_load_btf(void *btf, __u32 btf_size, char *log_buf,
>> LIBBPF_API int bpf_task_fd_query(int pid, int fd, __u32 flags, char *buf,
>>                                 __u32 *buf_len, __u32 *prog_id, __u32 *fd_type,
>>                                 __u64 *probe_offset, __u64 *probe_addr);
>> +LIBBPF_API int bpf_enable_stats(enum bpf_stats_type type);
>> 
>> #ifdef __cplusplus
>> } /* extern "C" */
>> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
>> index bb8831605b25..ebd946faada5 100644
>> --- a/tools/lib/bpf/libbpf.map
>> +++ b/tools/lib/bpf/libbpf.map
>> @@ -254,3 +254,8 @@ LIBBPF_0.0.8 {
>>                bpf_program__set_lsm;
>>                bpf_set_link_xdp_fd_opts;
>> } LIBBPF_0.0.7;
>> +
>> +LIBBPF_0.0.9 {
>> +       global:
> 
> You forgot to pull and rebase. LIBBPF_0.0.9 is already in master.

Hmm.. I pulled earlier today. Let me pull again..

Thanks,
Song