lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Apr 2020 12:38:35 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Rylan Dmello <mail@...an.coffee> Cc: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, netdev@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com> Subject: Re: [PATCH v2 2/7] staging: qlge: Remove gotos from ql_set_mac_addr_reg On Wed, Apr 29, 2020 at 09:33:04PM -0400, Rylan Dmello wrote: > As suggested by Joe Perches, this patch removes the 'exit' label > from the ql_set_mac_addr_reg function and replaces the goto > statements with break statements. > > Signed-off-by: Rylan Dmello <mail@...an.coffee> > --- > drivers/staging/qlge/qlge_main.c | 15 ++++++--------- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > index 29610618c7c0..f2b4a54fc4c0 100644 > --- a/drivers/staging/qlge/qlge_main.c > +++ b/drivers/staging/qlge/qlge_main.c > @@ -336,22 +336,20 @@ static int ql_set_mac_addr_reg(struct ql_adapter *qdev, u8 *addr, u32 type, > > status = ql_wait_reg_rdy(qdev, MAC_ADDR_IDX, MAC_ADDR_MW, 0); > if (status) > - goto exit; > + break; Just "return status". A direct return is immediately clear but with a break statement then you have to look down a bit and then scroll back. regards, dan carpenter
Powered by blists - more mailing lists