netdev - Re: [PATCH bpf-next] libbpf: fix probe code to return EPERM if encountered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tv11s0y1.fsf@toke.dk>
Date:   Thu, 30 Apr 2020 12:49:26 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Eelco Chaudron <echaudro@...hat.com>, bpf@...r.kernel.org
Cc:     davem@...emloft.net, netdev@...r.kernel.org, ast@...nel.org,
        daniel@...earbox.net, kafai@...com, songliubraving@...com,
        yhs@...com, andriin@...com
Subject: Re: [PATCH bpf-next] libbpf: fix probe code to return EPERM if encountered

Eelco Chaudron <echaudro@...hat.com> writes:

> When the probe code was failing for any reason ENOTSUP was returned, even
> if this was due to no having enough lock space. This patch fixes this by
> returning EPERM to the user application, so it can respond and increase
> the RLIMIT_MEMLOCK size.
>
> Signed-off-by: Eelco Chaudron <echaudro@...hat.com>

Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>

For context - we ran into this in xdp-tools where we've implemented
"fiddle rlimit and retry" logic in response to EPERM errors, and
suddenly we were seeing ENOTSUP errors instead. See discussion here:

https://github.com/xdp-project/xdp-tools/pull/16

-Toke