netdev - Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 09:38:20 +0800
From:   Samuel Zou <zou_wei@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <aviad.krawczyk@...wei.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next v2] hinic: Use ARRAY_SIZE for nic_vf_cmd_msg_handler



On 2020/4/30 2:43, David Miller wrote:
> From: Zou Wei <zou_wei@...wei.com>
> Date: Wed, 29 Apr 2020 12:17:40 +0800
> 
>> fix coccinelle warning, use ARRAY_SIZE
>>
>> drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use ARRAY_SIZE
>>
>> ----------
> 
> Please don't put this "-------" here.
> 
>> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> index b24788e..af70cca 100644
>> --- a/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> +++ b/drivers/net/ethernet/huawei/hinic/hinic_sriov.c
>> @@ -704,17 +704,15 @@ int nic_pf_mbox_handler(void *hwdev, u16 vf_id, u8 cmd, void *buf_in,
>>   	struct hinic_hwdev *dev = hwdev;
>>   	struct hinic_func_to_io *nic_io;
>>   	struct hinic_pfhwdev *pfhwdev;
>> -	u32 i, cmd_number;
>> +	u32 i;
>>   	int err = 0;
> 
> Please preserve the reverse christmas tree ordering of local variables.
> 
> .
> 
Thanks，I will modify and send v3 patch