netdev - Re: [PATCH net v2] mptcp: fix uninitialized value access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.123447.1558476832887483140.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 12:34:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        matthieu.baerts@...sares.net, kuba@...nel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net v2] mptcp: fix uninitialized value access

From: Paolo Abeni <pabeni@...hat.com>
Date: Thu, 30 Apr 2020 15:03:22 +0200

> tcp_v{4,6}_syn_recv_sock() set 'own_req' only when returning
> a not NULL 'child', let's check 'own_req' only if child is
> available to avoid an - unharmful - UBSAN splat.
> 
> v1 -> v2:
>  - reference the correct hash
> 
> Fixes: 4c8941de781c ("mptcp: avoid flipping mp_capable field in syn_recv_sock()")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.