netdev - Re: [PATCHv4 iproute2-next 2/7] iproute_lwtunnel: add options support for vxlan metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_cSTXakVS9qkiESu6swXPsEZyDvfPggQp1cWXYHg6hC5Q@mail.gmail.com>
Date:   Thu, 30 Apr 2020 13:12:31 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCHv4 iproute2-next 2/7] iproute_lwtunnel: add options support
 for vxlan metadata

On Thu, Apr 30, 2020 at 12:58 AM David Ahern <dsahern@...il.com> wrote:
>
> On 4/27/20 4:27 AM, Xin Long wrote:
> > diff --git a/ip/iproute_lwtunnel.c b/ip/iproute_lwtunnel.c
> > index 8599853..9945c86 100644
> > --- a/ip/iproute_lwtunnel.c
> > +++ b/ip/iproute_lwtunnel.c
> > @@ -333,6 +333,26 @@ static void lwtunnel_print_geneve_opts(struct rtattr *attr)
> >       close_json_array(PRINT_JSON, name);
> >  }
> >
> > +static void lwtunnel_print_vxlan_opts(struct rtattr *attr)
> > +{
> > +     struct rtattr *tb[LWTUNNEL_IP_OPT_VXLAN_MAX + 1];
> > +     struct rtattr *i = RTA_DATA(attr);
> > +     int rem = RTA_PAYLOAD(attr);
> > +     char *name = "vxlan_opts";
> > +     __u32 gbp;
> > +
> > +     parse_rtattr(tb, LWTUNNEL_IP_OPT_VXLAN_MAX, i, rem);
> > +     gbp = rta_getattr_u32(tb[LWTUNNEL_IP_OPT_VXLAN_GBP]);
> > +
> > +     print_nl();
> > +     print_string(PRINT_FP, name, "\t%s ", name);
> > +     open_json_array(PRINT_JSON, name);
> > +     open_json_object(NULL);
> > +     print_uint(PRINT_ANY, "gdp", "%u ", gbp);
>
> gdp? should that be 'gbp'?
Right, should be 'gbp'. Sorry.
The same mistake also exists in:

  [PATCHv4 iproute2-next 4/7] tc: m_tunnel_key: add options support for vxlan

Any other comments? Otherwise, I will post v5 with the fix.

Thanks.