netdev - Re: [PATCH net] ibmvnic: Skip fatal error reset after passive init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.132819.1445821468387589728.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 13:28:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     julietk@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Skip fatal error reset after passive init

From: Juliet Kim <julietk@...ux.vnet.ibm.com>
Date: Thu, 30 Apr 2020 13:22:11 -0500

> During MTU change, the following events may happen.
> Client-driven CRQ initialization fails due to partner’s CRQ closed,
> causing client to enqueue a reset task for FATAL_ERROR. Then passive
> (server-driven) CRQ initialization succeeds, causing client to
> release CRQ and enqueue a reset task for failover. If the passive
> CRQ initialization occurs before the FATAL reset task is processed,
> the FATAL error reset task would try to access a CRQ message queue
> that was freed, causing an oops. The problem may be most likely to
> occur during DLPAR add vNIC with a non-default MTU, because the DLPAR
> process will automatically issue a change MTU request.
> 
> Fix this by not processing fatal error reset if CRQ is passively
> initialized after client-driven CRQ initialization fails.
> 
> Signed-off-by: Juliet Kim <julietk@...ux.vnet.ibm.com>

Applied, thanks.