netdev - Re: Don't initialise ports with no PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f9f07dc2ed.5db66924@auth.smtp.1and1.co.uk>
Date:   Thu, 30 Apr 2020 21:45:14 +0100 (BST)
From:   Darren Stevens <darren@...vens-zone.net>
To:     Andrew Lunn <andrew@...n.ch>
CC:     oss@...error.net, netdev@...r.kernel.org, madalin.bacur@....com,
        linuxppc-dev@...ts.ozlabs.org, chzigotzky@...osoft.de
Subject: Re: Don't initialise ports with no PHY

Hello Andrew

On 25/04/2020, Andrew Lunn wrote:
> On Fri, Apr 24, 2020 at 11:29:38PM +0100, Darren Stevens wrote:
>> Since cbb961ca271e ("Use random MAC address when none is given")
>> Varisys Cyrus P5020 boards have been listing 5 ethernet ports instead of
>> the 2 the board has.This is because we were preventing the adding of the
>> unused ports by not suppling them a MAC address, which this patch now
>> supplies.
>> 
>> Prevent them from appearing in the net devices list by checking for a
>> 'status="disabled"' entry during probe and skipping the port if we find
>> it. 
>
> Hi Darren
>
> I'm surprised the core is probing a device which has status disabled.
> Are you sure this is the correct explanation?

You are correct, the core is detecting status="disabled". My mistake, the Hardware vendor's supplied dts always relied on only supplying active ports with an IP address, and it didn't occur to me to test that they could be disabled.

Sorry.

Regards
Darren