netdev - Re: [PATCH net-next] erspan: Add type I version 0 support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.180953.610137603497201056.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 18:09:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     u9012063@...il.com
Cc:     netdev@...r.kernel.org, petrm@...lanox.com, lucien.xin@...il.com,
        guy@...m.mit.edu, dandreye@...co.com
Subject: Re: [PATCH net-next] erspan: Add type I version 0 support.

From: William Tu <u9012063@...il.com>
Date: Sun, 26 Apr 2020 08:05:11 -0700

> index 029b24eeafba..b5c5fb329f31 100644
> --- a/net/ipv4/ip_gre.c
> +++ b/net/ipv4/ip_gre.c
> @@ -248,6 +248,15 @@ static void gre_err(struct sk_buff *skb, u32 info)
>  	ipgre_err(skb, info, &tpi);
>  }
>  
> +static inline bool is_erspan_type1(int gre_hdr_len)
> +{

Please do not use the inline keyword in foo.c files, let the compiler decide.