[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5eac4a51d61ab_2dd52ac42ee805b8af@john-XPS-13-9370.notmuch>
Date: Fri, 01 May 2020 09:12:01 -0700
From: John Fastabend <john.fastabend@...il.com>
To: Jakub Sitnicki <jakub@...udflare.com>,
John Fastabend <john.fastabend@...il.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org,
kernel-team@...udflare.com, Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Joe Stringer <joe@...d.net.nz>,
Lorenz Bauer <lmb@...udflare.com>,
Martin KaFai Lau <kafai@...com>
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: Test that lookup on
SOCKMAP/SOCKHASH is allowed
Jakub Sitnicki wrote:
> On Wed, Apr 29, 2020 at 09:23 PM CEST, John Fastabend wrote:
> > Jakub Sitnicki wrote:
> >> Now that bpf_map_lookup_elem() is white-listed for SOCKMAP/SOCKHASH,
> >> replace the tests which check that verifier prevents lookup on these map
> >> types with ones that ensure that lookup operation is permitted, but only
> >> with a release of acquired socket reference.
> >>
> >> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> >> ---
> >
> > For completeness would be nice to add a test passing this into
> > sk_select_reuseport to cover that case as well. Could come as
> > a follow up patch imo.
>
> Is this what you had in mind?
Yes thanks!
>
> https://lore.kernel.org/bpf/20200430104738.494180-1-jakub@cloudflare.com/
>
> Thanks for reviewing the series.
Powered by blists - more mailing lists