netdev - Re: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 1 May 2020 20:13:51 +0200
From:   Roelof Berg <rberg@...g-solutions.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lan743x: Added fixed_phy support / Question regarding
 proper devicetree

Working status: I added fixed_phy support to the Microchip lan743x ethernet driver and for upstream contribution I need to make it runtime configurable via the device tree.

Question:

There are, amongst other, the following devices on my target (i.mx6): 
/soc/aips-bus@...0000/ethernet@...8000
/soc/pcie@...c000

Where would I put my additional lan743x ethernet device in the device tree ?

a) /ethernet@0
    (Just a new root node.

b) /pci@...thernet@0
    (I would „invent“ pci@0 to reflect that the lan7431 is sitting on the first pci slot.

c) /soc/pcie@...c000/ethernet@0
    (That doesn’t feel right to me, it’s not a soc property. Or is it ?

Example:

        pci0 {
                ethernet@0 {
                        compatible = "rmtl-meu-hl“;
                        status = "okay“;
                        phy-connection-type = "rgmii“;
                        
                        fixed-link {
                                speed = <100>;
                                full-duplex;
                        };
                };
                
        }

Thanks a lot,
Roelof

> 
>> […] device tree is the way to go. […]
>> 
>> 	  Andrew
>