netdev - Re: [PATCH net-next v2] devlink: let kernel allocate region snapshot id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200501143251.1f7026ab@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 1 May 2020 14:32:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:     Jiri Pirko <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-team@...com" <kernel-team@...com>
Subject: Re: [PATCH net-next v2] devlink: let kernel allocate region
 snapshot id

On Fri, 1 May 2020 21:23:25 +0000 Keller, Jacob E wrote:
> > Could you please send the snapshot id just before you return 0 in this
> > function, as you offered in v1? I think it would be great to do it like
> > that.
> > 
> 
> Also: Does it make sense to send the snapshot id regardless of
> whether it was auto-generated or not?

I may be wrong, but I think sending extra messages via netlink,
which user space may not expect based on previous kernel versions 
is considered uAPI breakage.