netdev - Re: [PATCH net-next] net: fix skb_panic to output real address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 01 May 2020 15:20:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     netdev@...r.kernel.org, me@...in.cc
Subject: Re: [PATCH net-next] net: fix skb_panic to output real address

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Mon, 27 Apr 2020 18:37:43 +0200

> In skb_panic() the real pointer values are really needed to diagnose
> issues, e.g. data and head are related (to calculate headroom). The
> hashed versions of the addresses doesn't make much sense here. The
> patch use the printk specifier %px to print the actual address.
> 
> The printk documentation on %px:
> https://www.kernel.org/doc/html/latest/core-api/printk-formats.html#unmodified-addresses
> 
> Fixes: ad67b74d2469 ("printk: hash addresses printed with %p")
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>

Applied.