netdev - Re: [PATCH net-next] net: bcmgenet: Move wake-up event out of side band ISR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200501.155445.1145592921900948285.davem@davemloft.net>
Date:   Fri, 01 May 2020 15:54:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     opendmb@...il.com
Cc:     f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: bcmgenet: Move wake-up event out of side
 band ISR

From: Doug Berger <opendmb@...il.com>
Date: Thu, 30 Apr 2020 16:26:51 -0700

> The side band interrupt service routine is not available on chips
> like 7211, or rather, it does not permit the signaling of wake-up
> events due to the complex interrupt hierarchy.
> 
> Move the wake-up event accounting into a .resume_noirq function,
> account for possible wake-up events and clear the MPD/HFB interrupts
> from there, while leaving the hardware untouched until the resume
> function proceeds with doing its usual business.
> 
> Because bcmgenet_wol_power_down_cfg() now enables the MPD and HFB
> interrupts, it is invoked by a .suspend_noirq function to prevent
> the servicing of interrupts after the clocks have been disabled.
> 
> Signed-off-by: Doug Berger <opendmb@...il.com>

Applied, thank you.