netdev - Re: [PATCH v1] net: macb: Fix runtime PM refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.202806.326255312382467500.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 20:28:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com
Subject: Re: [PATCH v1] net: macb: Fix runtime PM refcounting

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Mon, 27 Apr 2020 13:51:20 +0300

> The commit e6a41c23df0d, while trying to fix an issue,
> 
>     ("net: macb: ensure interface is not suspended on at91rm9200")
> 
> introduced a refcounting regression, because in error case refcounter
> must be balanced. Fix it by calling pm_runtime_put_noidle() in error case.
> 
> While here, fix the same mistake in other couple of places.
> 
> Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on at91rm9200")
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied, thank you.