netdev - Re: [PATCH net] tunnel: Propagate ECT(1) when decapsulating as recommended by RFC6040

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.203319.977198547891023040.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 20:33:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     toke@...hat.com
Cc:     netdev@...r.kernel.org, ietf@...briscoe.net,
        olivier.tilmans@...ia-bell-labs.com, dave.taht@...il.com,
        stephen@...workplumber.org
Subject: Re: [PATCH net] tunnel: Propagate ECT(1) when decapsulating as
 recommended by RFC6040

From: Toke Høiland-Jørgensen <toke@...hat.com>
Date: Mon, 27 Apr 2020 16:11:05 +0200

> RFC 6040 recommends propagating an ECT(1) mark from an outer tunnel header
> to the inner header if that inner header is already marked as ECT(0). When
> RFC 6040 decapsulation was implemented, this case of propagation was not
> added. This simply appears to be an oversight, so let's fix that.
> 
> Fixes: eccc1bb8d4b4 ("tunnel: drop packet if ECN present with not-ECT")
> Reported-by: Bob Briscoe <ietf@...briscoe.net>
> Reported-by: Olivier Tilmans <olivier.tilmans@...ia-bell-labs.com>
> Cc: Dave Taht <dave.taht@...il.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Applied and queued up for -stable, thanks.