netdev - Re: [PATCH v1] stmmac: intel: Fix kernel crash due to wrong error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.210037.2294375960459896634.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 21:00:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andriy.shevchenko@...ux.intel.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, linux-stm32@...md-mailman.stormreply.com,
        netdev@...r.kernel.org, weifeng.voon@...el.com,
        boon.leong.ong@...el.com
Subject: Re: [PATCH v1] stmmac: intel: Fix kernel crash due to wrong error
 path

From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Date: Wed, 29 Apr 2020 18:09:32 +0300

> Unfortunately sometimes ->probe() may fail. The commit b9663b7ca6ff
> ("net: stmmac: Enable SERDES power up/down sequence")
> messed up with error handling and thus:
> 
> [   12.811311] ------------[ cut here ]------------
> [   12.811993] kernel BUG at net/core/dev.c:9937!
> 
> Fix this by properly crafted error path.
> 
> Fixes: b9663b7ca6ff ("net: stmmac: Enable SERDES power up/down sequence")
> Cc: Voon Weifeng <weifeng.voon@...el.com>
> Cc: Ong Boon Leong <boon.leong.ong@...el.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Applied.