lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 30 Apr 2020 21:02:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.lakkireddy@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com, vishal@...lsio.com,
        dt@...lsio.com
Subject: Re: [PATCH net] cxgb4: fix EOTID leak when disabling TC-MQPRIO
 offload

From: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>
Date: Thu, 30 Apr 2020 00:22:19 +0530

> Under heavy load, the EOTID termination FLOWC request fails to get
> enqueued to the end of the Tx ring due to lack of credits. This
> results in EOTID leak.
> 
> When disabling TC-MQPRIO offload, the link is already brought down
> to cleanup EOTIDs. So, flush any pending enqueued skbs that can't be
> sent outside the wire, to make room for FLOWC request. Also, move the
> FLOWC descriptor consumption logic closer to when the FLOWC request is
> actually posted to hardware.
> 
> Fixes: 0e395b3cb1fb ("cxgb4: add FLOWC based QoS offload")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@...lsio.com>

Applied and queued up for -stable, thanks.

Powered by blists - more mailing lists