netdev - Re: [PATCH] dp83640: reverse arguments to list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200430.174919.939495831904691325.davem@davemloft.net>
Date:   Thu, 30 Apr 2020 17:49:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Julia.Lawall@...ia.fr
Cc:     richardcochran@...il.com, kernel-janitors@...r.kernel.org,
        andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, eugene.volanschi@...ia.fr
Subject: Re: [PATCH] dp83640: reverse arguments to list_add_tail

From: Julia Lawall <Julia.Lawall@...ia.fr>
Date: Thu, 30 Apr 2020 21:51:32 +0200

> In this code, it appears that phyter_clocks is a list head, based on
> the previous list_for_each, and that clock->list is intended to be a
> list element, given that it has just been initialized in
> dp83640_clock_init.  Accordingly, switch the arguments to
> list_add_tail, which takes the list head as the second argument.
> 
> Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.")
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>

This looks correct to me too.

Applied and queued up for -stable, thanks.