lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 May 2020 09:54:45 +0000 From: "Jubran, Samih" <sameehj@...zon.com> To: Jakub Kicinski <kuba@...nel.org> CC: "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kiyanovski, Arthur" <akiyano@...zon.com>, "Woodhouse, David" <dwmw@...zon.co.uk>, "Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky, Alexander" <matua@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Wilson, Matt" <msw@...zon.com>, "Liguori, Anthony" <aliguori@...zon.com>, "Bshara, Nafea" <nafea@...zon.com>, "Tzalik, Guy" <gtzalik@...zon.com>, "Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>, "Herrenschmidt, Benjamin" <benh@...zon.com>, "Dagan, Noam" <ndagan@...zon.com> Subject: RE: [PATCH V2 net-next 11/13] net: ena: move llq configuration from ena_probe to ena_device_init() > -----Original Message----- > From: Jakub Kicinski <kuba@...nel.org> > Sent: Tuesday, April 28, 2020 10:46 PM > To: Jubran, Samih <sameehj@...zon.com> > Cc: davem@...emloft.net; netdev@...r.kernel.org; Kiyanovski, Arthur > <akiyano@...zon.com>; Woodhouse, David <dwmw@...zon.co.uk>; > Machulsky, Zorik <zorik@...zon.com>; Matushevsky, Alexander > <matua@...zon.com>; Bshara, Saeed <saeedb@...zon.com>; Wilson, > Matt <msw@...zon.com>; Liguori, Anthony <aliguori@...zon.com>; > Bshara, Nafea <nafea@...zon.com>; Tzalik, Guy <gtzalik@...zon.com>; > Belgazal, Netanel <netanel@...zon.com>; Saidi, Ali > <alisaidi@...zon.com>; Herrenschmidt, Benjamin <benh@...zon.com>; > Dagan, Noam <ndagan@...zon.com> > Subject: RE: [EXTERNAL] [PATCH V2 net-next 11/13] net: ena: move llq > configuration from ena_probe to ena_device_init() > > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On Tue, 28 Apr 2020 07:27:24 +0000 sameehj@...zon.com wrote: > > + ena_dev->mem_bar = devm_ioremap_wc(&pdev->dev, > > + pci_resource_start(pdev, ENA_MEM_BAR), > > + pci_resource_len(pdev, ENA_MEM_BAR)); > > Is there anything that'd undo the mapping in case of reset? > > The use of devm_ functions outside of probe seems questionable. I agree, dropped patch in v3.
Powered by blists - more mailing lists