netdev - Re: [PATCH] net: rtw88: fix an issue about leak system resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 15:51:57 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Brian Norris <briannorris@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Kalle Valo <kvalo@...eaurora.org>,
        Stanislaw Gruszka <sgruszka@...hat.com>,
        Yan-Hsuan Chuang <yhchuang@...ltek.com>
Subject: Re: [PATCH] net: rtw88: fix an issue about leak system resources

> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()

   Change description:
   A call of the function “pci_request_regions” can fail here.
   The corresponding system resources were not released then.
   Thus add a call of the function “pci_release_regions”.


Regards,
Markus