netdev - Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <af38eb97-d734-3911-2f5d-eb666deaad7e@web.de>
Date:   Mon, 4 May 2020 17:42:24 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Maxim Petrov <mmrmaximuzz@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...com>,
        "David S. Miller" <davem@...emloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH v2] stmmac: fix pointer check after utilization in
 stmmac_interrupt

> … However, the code fragment is incorrect
> because the dev pointer is used before the actual check

I find such information interesting.


> which leads to undefined behavior. …

I suggest to adjust the wording for this “conclusion”.

Regards,
Markus