netdev - Re: [PATCH] nfp: abm: fix a memory leak bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200504100128.06221170@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 May 2020 10:01:28 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     wu000273@....edu
Cc:     davem@...emloft.net, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kjlu@....edu
Subject: Re: [PATCH] nfp: abm: fix a memory leak bug

On Sat,  2 May 2020 17:42:59 -0500 wu000273@....edu wrote:
> From: Qiushi Wu <wu000273@....edu>
> 
> In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
> which can lead to a memory leak bug. Fix this issue by adding
> nfp_nsp_close(nsp) in the error path.
> 
> Signed-off-by: Qiushi Wu <wu000273@....edu>

Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
Acked-by: Jakub Kicinski <kuba@...nel.org>