netdev - Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to be disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200504.111620.1983042701063972335.davem@davemloft.net>
Date:   Mon, 04 May 2020 11:16:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michael@...le.cc
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, f.fainelli@...il.com,
        vivien.didelot@...il.com, andrew@...n.ch, claudiu.manoil@....com,
        vladimir.oltean@....com, shawnguo@...nel.org
Subject: Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to
 be disabled

From: Michael Walle <michael@...le.cc>
Date: Mon,  4 May 2020 18:52:28 +0200

> If there is no specific configuration of the felix switch in the device
> tree, but only the default configuration (ie. given by the SoCs dtsi
> file), the probe fails because no CPU port has been set. On the other
> hand you cannot set a default CPU port because that depends on the
> actual board using the switch.
> 
> [    2.701300] DSA: tree 0 has no CPU port
> [    2.705167] mscc_felix 0000:00:00.5: Failed to register DSA switch: -22
> [    2.711844] mscc_felix: probe of 0000:00:00.5 failed with error -22
> 
> Thus let the device tree disable this device entirely, like it is also
> done with the enetc driver of the same SoC.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>

Applied, thank you.