netdev - Re: [PATCH bpf-next 1/2] xsk: change two variable names for increased clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BF768ECB-A68A-464B-B70A-780B68F356C4@gmail.com>
Date:   Mon, 04 May 2020 12:13:55 -0700
From:   "Jonathan Lemon" <jonathan.lemon@...il.com>
To:     "Magnus Karlsson" <magnus.karlsson@...el.com>
Cc:     bjorn.topel@...el.com, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next 1/2] xsk: change two variable names for increased
 clarity



On 4 May 2020, at 6:33, Magnus Karlsson wrote:

> Change two variables names so that it is clearer what they
> represent. The first one is xsk_list that in fact only contains the
> list of AF_XDP sockets with a Tx component. Change this to xsk_tx_list
> for improved clarity. The second variable is size in the ring
> structure. One might think that this is the size of the ring, but it
> is in fact the size of the umem, copied into the ring structure to
> improve performance. Rename this variable umem_size to avoid any
> confusion.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>

Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>