netdev - Re: bgmac-enet driver broken in 5.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed1c2d8f-9d92-1258-e15b-ee33acac8859@gmail.com>
Date:   Mon, 4 May 2020 13:36:13 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jonathan Richardson <jonathan.richardson@...adcom.com>
Cc:     zhengdejin5@...il.com, davem@...emloft.net,
        Scott Branden <scott.branden@...adcom.com>,
        Ray Jui <ray.jui@...adcom.com>, netdev@...r.kernel.org
Subject: Re: bgmac-enet driver broken in 5.7



On 5/4/2020 1:24 PM, Jonathan Richardson wrote:
> On Mon, May 4, 2020 at 1:20 PM Florian Fainelli <f.fainelli@...il.com> wrote:
>>
>>
>>
>> On 5/4/2020 12:32 PM, Jonathan Richardson wrote:
>>> Hi,
>>>
>>> Commit d7a5502b0bb8b (net: broadcom: convert to
>>> devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
>>> probe fails with -22. idm_base and nicpm_base were optional. Now they
>>> are mandatory. Our upstream dtb doesn't have them defined. I'm not
>>> clear on why this change was made. Can it be reverted?
>>
>> You don't get a change reverted by just asking for it, you have to
>> submit a revert to get that done can you do that?
>> --
>> Florian
> 
> If the author is fine with reverting it yes I will submit the change.

The author clearly submitted this as a drive by contribution, so I would
not expect this to be a problem.
-- 
Florian