lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 4 May 2020 09:34:52 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>, netdev@...r.kernel.org
Cc:     oss-drivers@...ronome.com, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH v3] nfp: abm: Fix incomplete release of system resources
 in nfp_abm_vnic_set_mac()

> But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,

Do you distinguish between releasing items and the role of such a pointer?


> which can lead to a memory leak bug.

Would you like to reconsider the usage of the word “can” for
such change descriptions?

Regards,
Markus

Powered by blists - more mailing lists