netdev - Re: Net: [DSA]: dsa-loop kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82bc0bdf-e4f6-2b85-d2ad-54632b287a60@gmail.com>
Date:   Sun, 3 May 2020 20:40:33 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Allen <allen.pais@...cle.com>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: Net: [DSA]: dsa-loop kernel panic



On 5/3/2020 2:06 PM, Florian Fainelli wrote:
> Le 2020-05-01 à 10:58, Allen a écrit :
>>>>
>>>>   It maps to "eth0". Please let me know if you need further details.
>>>
>>> I suppose I should have been clearer, what network device driver created
>>> eth0?
>>>
>>
>>  This was seen on a VM.
>> eth0 [52:54:00:c1:cd:65]: virtio_net (up)
> 
> I have reproduced it here with virtio_net and am now looking into this,
> at first glance it does not look like we are properly holding the device
> reference count for the case where DSA was probed via platform device
> configuration.

There is a DSA master reference counting issue, but with dsa-loop, the
DSA master is already properly reference counted thanks to the
dev_get_by_name() call, I will keep digging.
-- 
Florian