netdev - RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <88e6cc654a73472f9591fb0c6b74f768@realtek.com>
Date:   Mon, 4 May 2020 08:37:15 +0000
From:   Tony Chuang <yhchuang@...ltek.com>
To:     Dejin Zheng <zhengdejin5@...il.com>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "sgruszka@...hat.com" <sgruszka@...hat.com>,
        "briannorris@...omium.org" <briannorris@...omium.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Andy Shevchenko" <andy.shevchenko@...il.com>
Subject: RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources

> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources
> 
> the related system resources were not released when pci_iomap() return
> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
> fix it.
> 
> Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac driver")
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>
Acked-by: Yan-Hsuan Chuang <yhchuang@...ltek.com>
> ---
>  drivers/net/wireless/realtek/rtw88/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/pci.c
> b/drivers/net/wireless/realtek/rtw88/pci.c
> index 695c2c0d64b0..a9752c34c9d8 100644
> --- a/drivers/net/wireless/realtek/rtw88/pci.c
> +++ b/drivers/net/wireless/realtek/rtw88/pci.c
> @@ -1102,6 +1102,7 @@ static int rtw_pci_io_mapping(struct rtw_dev
> *rtwdev,
>  	len = pci_resource_len(pdev, bar_id);
>  	rtwpci->mmap = pci_iomap(pdev, bar_id, len);
>  	if (!rtwpci->mmap) {
> +		pci_release_regions(pdev);
>  		rtw_err(rtwdev, "failed to map pci memory\n");
>  		return -ENOMEM;
>  	}
> --
> 2.25.0