netdev - [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  5 May 2020 12:42:15 +0200
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Oleksij Rempel <o.rempel@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Marek Vasut <marex@...x.de>, David Jander <david@...tonic.nl>,
        devicetree@...r.kernel.org
Subject: [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support

To properly identify this node, we need to use ethernet-phy-id0180.dc80.
And add missing required properties.

Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
---
 .../devicetree/bindings/net/nxp,tja11xx.yaml  | 55 ++++++++++++-------
 1 file changed, 35 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
index 42be0255512b3..cc322107a24a2 100644
--- a/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
+++ b/Documentation/devicetree/bindings/net/nxp,tja11xx.yaml
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0+
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
 $id: http://devicetree.org/schemas/net/nxp,tja11xx.yaml#
@@ -12,44 +12,59 @@ maintainers:
   - Heiner Kallweit <hkallweit1@...il.com>
 
 description:
-  Bindings for NXP TJA11xx automotive PHYs
+  Bindings for the NXP TJA1102 automotive PHY. This is a dual PHY package where
+  only the first PHY has global configuration register and HW health
+  monitoring.
 
-allOf:
-  - $ref: ethernet-phy.yaml#
+properties:
+  compatible:
+    const: ethernet-phy-id0180.dc80
+    description: ethernet-phy-id0180.dc80 used for TJA1102 PHY
+
+  reg:
+    minimum: 0
+    maximum: 14
+    description:
+      The PHY address of the parent PHY.
+
+  '#address-cells':
+    description: number of address cells for the MDIO bus
+    const: 1
+
+  '#size-cells':
+    description: number of size cells on the MDIO bus
+    const: 0
 
 patternProperties:
-  "^ethernet-phy@[0-9a-f]+$":
+  "^ethernet-phy@[0-9a-f]$":
     type: object
-    description: |
-      Some packages have multiple PHYs. Secondary PHY should be defines as
-      subnode of the first (parent) PHY.
+    description:
+      Integrated PHY node
 
     properties:
       reg:
-        minimum: 0
-        maximum: 31
+        minimum: 1
+        maximum: 15
         description:
-          The ID number for the child PHY. Should be +1 of parent PHY.
+          The PHY address of the slave PHY. Should be +1 of parent PHY.
 
     required:
       - reg
 
-examples:
-  - |
-    mdio {
-        #address-cells = <1>;
-        #size-cells = <0>;
+required:
+  - compatible
+  - reg
+  - '#address-cells'
+  - '#size-cells'
 
-        tja1101_phy0: ethernet-phy@4 {
-            reg = <0x4>;
-        };
-    };
+examples:
   - |
     mdio {
         #address-cells = <1>;
         #size-cells = <0>;
 
         tja1102_phy0: ethernet-phy@4 {
+            compatible = "ethernet-phy-id0180.dc80";
             reg = <0x4>;
             #address-cells = <1>;
             #size-cells = <0>;
-- 
2.26.2