netdev - Re: [PATCH net-next v2 09/10] net: phy: Put interface into oper testing during cable test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 13:26:48 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>, michael@...le.cc
Subject: Re: [PATCH net-next v2 09/10] net: phy: Put interface into oper
 testing during cable test

On Tue, May 05, 2020 at 02:18:20AM +0200, Andrew Lunn wrote:
> Since running a cable test is disruptive, put the interface into
> operative state testing while the test is running.
> 
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
> ---

Reviewed-by: Michal Kubecek <mkubecek@...e.cz>

Things could be simplified a bit by putting netif_testing_off() into
ethnl_cable_test_finished() but it's probably not worth the confusion
from setting the state in one place and clearing it in a completely
different one.

Michal