netdev - Re: [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable test reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 15:15:48 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Chris Healy <cphealy@...il.com>, michael@...le.cc
Subject: Re: [PATCH net-next v2 04/10] net: ethtool: Add attributes for cable
 test reports

> > + +---------------------------------------------+--------+---------------------+
> > + | ``ETHTOOL_A_CABLE_TEST_HEADER``             | nested | reply header        |
> > + +---------------------------------------------+--------+---------------------+
> > + | ``ETHTOOL_A_CABLE_TEST_STATUS``             | u8     | completed           |
> > + +---------------------------------------------+--------+---------------------+
> > + | ``ETHTOOL_A_CABLE_TEST_NTF_NEST``           | nested | all the results     |
> > + +-+-------------------------------------------+--------+---------------------+
> > + | | ``ETHTOOL_A_CABLE_TEST_STATUS``           | u8     | completed           |
> > + +-+-------------------------------------------+--------+---------------------+
> 
> You have ETHTOOL_A_CABLE_TEST_STATUS both here and on top level. AFAICS
> the top level attribute is the right one - but the name is
> ETHTOOL_A_CABLE_TEST_NTF_STATUS.

Hi Michal

They need better names. The first one is about the test run
status. Started vs complete. A notification is sent when the test is
started, and a second one at the end with the actual test results. The
second status is per pair, indicating open, shorted, O.K.
Maybe this second one shouldd be ETHTOOL_A_CABLE_TEST_NTF_PAIR_STATUS.

There is also a cut/paste error, the second one should not have the
comment completed.

	Andrew