netdev - Re: [PATCH] [net-next] dsa: sja1105: dynamically allocate stats structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 16:04:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>,
        Nathan Chancellor <natechancellor@...il.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] [net-next] dsa: sja1105: dynamically allocate stats
 structure

> -	rc = sja1105_port_status_get(priv, &status, port);
> +	rc = sja1105_port_status_get(priv, status, port);
>  	if (rc < 0) {
>  		dev_err(ds->dev, "Failed to read port %d counters: %d\n",
>  			port, rc);
> -		return;
> +		goto out;;

Hi Arnd

I expect static checker people will drive by soon with a fix for the ;; :-)

  Andrew