netdev - Re: [PATCH iproute2-next v3] devlink: support kernel-side snapshot id allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200505092009.1cfe01c0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 5 May 2020 09:20:09 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...il.com>
Cc:     davem@...emloft.net, jiri@...nulli.us, netdev@...r.kernel.org,
        kernel-team@...com, jacob.e.keller@...el.com
Subject: Re: [PATCH iproute2-next v3] devlink: support kernel-side snapshot
 id allocation

On Tue, 5 May 2020 10:14:24 -0600 David Ahern wrote:
> On 4/30/20 11:57 AM, Jakub Kicinski wrote:
> > Make ID argument optional and read the snapshot info
> > that kernel sends us.
> > 
> > $ devlink region new netdevsim/netdevsim1/dummy
> > netdevsim/netdevsim1/dummy: snapshot 0
> > $ devlink -jp region new netdevsim/netdevsim1/dummy
> > {
> >     "regions": {
> >         "netdevsim/netdevsim1/dummy": {
> >             "snapshot": [ 1 ]
> >         }
> >     }
> > }
> > $ devlink region show netdevsim/netdevsim1/dummy
> > netdevsim/netdevsim1/dummy: size 32768 snapshot [0 1]
> > 
> > v3: back to v1..
> > 
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > ---
> >  devlink/devlink.c | 26 +++++++++++++++++++++++---
> >  1 file changed, 23 insertions(+), 3 deletions(-)  
> 
> this does not apply to current iproute2-next

Hm. This was on top of Jake's patch, but Stephen took that one into
iproute2, since the kernel feature is in 5.7 already. What is the
protocol here? Can you merge iproute2 into iproute2-next? :S