netdev - Re: bgmac-enet driver broken in 5.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200505022143.GA31724@nuc8i5>
Date:   Tue, 5 May 2020 10:21:43 +0800
From:   Dejin Zheng <zhengdejin5@...il.com>
To:     Jonathan Richardson <jonathan.richardson@...adcom.com>
Cc:     davem@...emloft.net, Scott Branden <scott.branden@...adcom.com>,
        Ray Jui <ray.jui@...adcom.com>, netdev@...r.kernel.org
Subject: Re: bgmac-enet driver broken in 5.7

On Mon, May 04, 2020 at 05:37:18PM -0700, Jonathan Richardson wrote:
> On Mon, May 4, 2020 at 5:30 PM Dejin Zheng <zhengdejin5@...il.com> wrote:
> >
> > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote:
> > > Hi,
> > >
> > > Commit d7a5502b0bb8b (net: broadcom: convert to
> > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver.
> > > probe fails with -22. idm_base and nicpm_base were optional. Now they
> > > are mandatory. Our upstream dtb doesn't have them defined. I'm not
> > > clear on why this change was made. Can it be reverted?
> > >
> > Jon, I am so sorry for that, I will submit a cl to reverted it to make
> > idm_base and nicpm_base as optional. sorry!
> 
> No problem. I'll let you submit the fix then. Thanks for taking care of it.

Thank you very much for giving me this opportunity to deal with my
mistakes. at the same time, I apologize for the trouble to bring you.
now, I have submitted a cl is here:
http://patchwork.ozlabs.org/project/netdev/patch/20200505020329.31638-1-zhengdejin5@gmail.com/

I hope it solves this problem. sorry! I will be more careful with each
new patch. Thanks!

BR,
Dejin