netdev - Re: [PATCH iproute2] ss: add support for Gbit speeds in sprint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 10:05:12 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Ahern <dsahern@...il.com>, netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH iproute2] ss: add support for Gbit speeds in sprint_bw()

On Tue,  5 May 2020 08:37:41 -0700
Eric Dumazet <edumazet@...gle.com> wrote:

> Also use 'g' specifier instead of 'f' to remove trailing zeros,
> and increase precision.
> 
> Examples of output :
>  Before        After
>  8.0Kbps       8Kbps
>  9.9Mbps       9.92Mbps
>  55001Mbps     55Gbps
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, and add terrabit as well.

It looks like tc and ss are not the same in suffix here.

https://en.wikipedia.org/wiki/Data-rate_units

kilobit per sec  = kbit/sec or kb/s = kbps
kilobyte per sec = kB/s
megabit per sec  = Mbit/sec or Mb/s = Mbps

For now, lets get ss to follow the standard. 
That means "kbps" instead of "Kbps"