netdev - Re: [PATCH net v2 0/2] Revert the 'socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200505.120049.635223866062154775.davem@davemloft.net>
Date:   Tue, 05 May 2020 12:00:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sjpark@...zon.com
Cc:     viro@...iv.linux.org.uk, kuba@...nel.org,
        gregkh@...uxfoundation.org, edumazet@...gle.com,
        sj38.park@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sjpark@...zon.de
Subject: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

From: David Miller <davem@...emloft.net>
Date: Tue, 05 May 2020 11:48:25 -0700 (PDT)

> Series applied and queued up for -stable, thanks.

Nevermind, this doesn't even compile.

net/smc/af_smc.c: In function ‘smc_switch_to_fallback’:
net/smc/af_smc.c:473:19: error: ‘smc->clcsock->wq’ is a pointer; did you mean to use ‘->’?
  473 |   smc->clcsock->wq.fasync_list =
      |                   ^
      |                   ->
net/smc/af_smc.c:474:25: error: ‘smc->sk.sk_socket->wq’ is a pointer; did you mean to use ‘->’?
  474 |    smc->sk.sk_socket->wq.fasync_list;
      |                         ^
      |                         ->

So I had to revert these changes.

When you make a change of this magnitude and scope you must do an
allmodconfig build.

Thank you.