[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 May 2020 13:33:50 -0700
From: Andrey Ignatov <rdna@...com>
To: Stanislav Fomichev <sdf@...gle.com>
CC: <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
<davem@...emloft.net>, <ast@...nel.org>, <daniel@...earbox.net>
Subject: Re: [PATCH bpf-next v2 4/5] bpf: allow any port in bpf_bind helper
Stanislav Fomichev <sdf@...gle.com> [Tue, 2020-05-05 13:27 -0700]:
> We want to have a tighter control on what ports we bind to in
> the BPF_CGROUP_INET{4,6}_CONNECT hooks even if it means
> connect() becomes slightly more expensive. The expensive part
> comes from the fact that we now need to call inet_csk_get_port()
> that verifies that the port is not used and allocates an entry
> in the hash table for it.
>
> Since we can't rely on "snum || !bind_address_no_port" to prevent
> us from calling POST_BIND hook anymore, let's add another bind flag
> to indicate that the call site is BPF program.
>
> v2:
> * Update documentation (Andrey Ignatov)
> * Pass BIND_FORCE_ADDRESS_NO_PORT conditionally (Andrey Ignatov)
>
> Cc: Andrey Ignatov <rdna@...com>
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
Thanks. LGMT.
Acked-by: Andrey Ignatov <rdna@...com>
--
Andrey Ignatov
Powered by blists - more mailing lists