netdev - Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 20:28:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dejin Zheng <zhengdejin5@...il.com>, davem@...emloft.net,
        swboyd@...omium.org, ynezz@...e.cz, netdev@...r.kernel.org,
        jonathan.richardson@...adcom.com
Cc:     linux-kernel@...r.kernel.org,
        Scott Branden <scott.branden@...adcom.com>,
        Ray Jui <ray.jui@...adcom.com>
Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap
 resource



On 5/4/2020 7:03 PM, Dejin Zheng wrote:
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()") will broke this driver.
> idm_base and nicpm_base were optional, after this change, they are
> mandatory. it will probe fails with -22 when the dtb doesn't have them
> defined. so revert part of this commit and make idm_base and nicpm_base
> as optional.
> 
> Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()")
> Reported-by: Jonathan Richardson <jonathan.richardson@...adcom.com>
> Cc: Scott Branden <scott.branden@...adcom.com>
> Cc: Ray Jui <ray.jui@...adcom.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian