netdev - Re: Re: [PATCH net 2/2] Revert "sockfs: switch to ->free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 10:09:23 +0200
From:   SeongJae Park <sjpark@...zon.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     SeongJae Park <sjpark@...zon.com>, <davem@...emloft.net>,
        <viro@...iv.linux.org.uk>, <kuba@...nel.org>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, SeongJae Park <sjpark@...zon.de>
Subject: Re: Re: [PATCH net 2/2] Revert "sockfs: switch to ->free_inode()"

On Tue, 5 May 2020 09:45:35 +0200 Greg KH <gregkh@...uxfoundation.org> wrote:

> On Tue, May 05, 2020 at 09:28:41AM +0200, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@...zon.de>
> > 
> > This reverts commit 6d7855c54e1e269275d7c504f8f62a0b7a5b3f18.
> > 
> > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the
> > deallocation of 'socket_alloc' to be done asynchronously using RCU, as
> > same to 'sock.wq'.
> > 
> > The change made 'socket_alloc' live longer than before.  As a result,
> > user programs intensively repeating allocations and deallocations of
> > sockets could cause memory pressure on recent kernels.
> > 
> > To avoid the problem, this commit reverts the change.
> > ---
> >  net/socket.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Same problems here as in patch 1/2 :(

Yes, indeed.  I will send next version right now.


Thanks,
SeongJae Park

>