netdev - Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment to xen-netback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJe8K3ieApcY_VmEx1fm4=vgKgWOs3__WSr4m+F8kkAAKX_uQ@mail.gmail.com>
Date:   Wed, 6 May 2020 20:45:09 +0300
From:   Denis Kirjanov <kda@...ux-powerpc.org>
To:     paul@....org
Cc:     netdev@...r.kernel.org, jgross@...e.com, wei.liu@...nel.org,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v7 2/2] xen networking: add XDP offset adjustment
 to xen-netback

On 5/5/20, Paul Durrant <xadimgnik@...il.com> wrote:
>> -----Original Message-----
>> >> @@ -417,6 +431,11 @@ static void frontend_changed(struct xenbus_device
>> >> *dev,
>> >>  		set_backend_state(be, XenbusStateConnected);
>> >>  		break;
>> >>
>> >> +	case XenbusStateReconfiguring:
>> >> +		read_xenbus_frontend_xdp(be, dev);
>> >
>> > Is the frontend always expected to trigger a re-configure, or could
>> > feature-xdp already be enabled prior to connection?
>>
>> Yes, feature-xdp is set by the frontend when  xdp code is loaded.
>>
>
> That's still ambiguous... what I'm getting at is whether you also need to
> read the xdp state when transitioning into Connected as well as
> Reconfiguring?

I have to read the state only during the Reconfiguring state since
that's where an XDP program is loaded / unloaded and then we transition
from Reconfigred to Connected

>
>   Paul
>
>