[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200506181401.28699-3-grygorii.strashko@ti.com>
Date: Wed, 6 May 2020 21:14:00 +0300
From: Grygorii Strashko <grygorii.strashko@...com>
To: "David S. Miller" <davem@...emloft.net>,
Rob Herring <robh+dt@...nel.org>, <devicetree@...r.kernel.org>,
Tero Kristo <t-kristo@...com>
CC: <netdev@...r.kernel.org>, Sekhar Nori <nsekhar@...com>,
<linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
Grygorii Strashko <grygorii.strashko@...com>,
Rob Herring <robh@...nel.org>
Subject: [PATCH net-next 2/3] dt-binding: net: ti: am65x-cpts: make reg and compatible required
This patch follows K3 CPTS review comments from Rob Herring
<robh@...nel.org>.
- "reg" and "compatible" properties are required now
- minor format changes
- K3 CPTS example added to K3 MCU CPSW bindings
Cc: Rob Herring <robh@...nel.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
---
.../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 15 ++++++++++-
.../bindings/net/ti,k3-am654-cpts.yaml | 25 +++++++------------
2 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
index 0c054a2ce5ba..c87395f360a6 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
@@ -144,7 +144,7 @@ patternProperties:
description:
CPSW MDIO bus.
- "^cpts$":
+ "^cpts@[0-9a-f]+":
type: object
allOf:
- $ref: "ti,k3-am654-cpts.yaml#"
@@ -171,6 +171,8 @@ examples:
#include <dt-bindings/pinctrl/k3.h>
#include <dt-bindings/soc/ti,sci_pm_domain.h>
#include <dt-bindings/net/ti-dp83867.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
mcu_cpsw: ethernet@...00000 {
compatible = "ti,am654-cpsw-nuss";
@@ -229,4 +231,15 @@ examples:
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
};
};
+
+ cpts@...00 {
+ compatible = "ti,am65-cpts";
+ reg = <0x0 0x3d000 0x0 0x400>;
+ clocks = <&k3_clks 18 2>;
+ clock-names = "cpts";
+ interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "cpts";
+ ti,cpts-ext-ts-inputs = <4>;
+ ti,cpts-periodic-outputs = <2>;
+ };
};
diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
index df83c320e61b..50e027911dd4 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
@@ -42,7 +42,7 @@ description: |+
properties:
$nodename:
- pattern: "^cpts(@.*|-[0-9a-f])*$"
+ pattern: "^cpts@[0-9a-f]+$"
compatible:
oneOf:
@@ -52,7 +52,7 @@ properties:
reg:
maxItems: 1
description:
- The physical base address and size of CPTS IO range
+ The physical base address and size of CPTS IO range
reg-names:
items:
@@ -65,27 +65,27 @@ properties:
items:
- const: cpts
- interrupts-extended:
+ interrupts:
items:
- description: CPTS events interrupt
interrupt-names:
items:
- - const: "cpts"
+ - const: cpts
ti,cpts-ext-ts-inputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
- Number of hardware timestamp push inputs (HWx_TS_PUSH)
+ Number of hardware timestamp push inputs (HWx_TS_PUSH)
ti,cpts-periodic-outputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
- Number of timestamp Generator function outputs (TS_GENFx)
+ Number of timestamp Generator function outputs (TS_GENFx)
refclk-mux:
type: object
@@ -107,9 +107,11 @@ properties:
- clocks
required:
+ - compatible
+ - reg
- clocks
- clock-names
- - interrupts-extended
+ - interrupts
- interrupt-names
additionalProperties: false
@@ -140,13 +142,4 @@ examples:
assigned-clock-parents = <&k3_clks 118 11>;
};
};
- - |
- cpts {
- clocks = <&k3_clks 18 2>;
- clock-names = "cpts";
- interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cpts";
- ti,cpts-ext-ts-inputs = <4>;
- ti,cpts-periodic-outputs = <2>;
- };
--
2.17.1
Powered by blists - more mailing lists