netdev - Re: [PATCH 2/2 net] net: mvpp2: cls: Prevent buffer overflow in mvpp2_ethtool_cls_rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200506.141814.1060708966400070196.davem@davemloft.net>
Date:   Wed, 06 May 2020 14:18:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     maxime.chevallier@...tlin.com, kuba@...nel.org, jiri@...lanox.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2 net] net: mvpp2: cls: Prevent buffer overflow in
 mvpp2_ethtool_cls_rule_del()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 6 May 2020 13:16:56 +0300

> The "info->fs.location" is a u32 that comes from the user via the
> ethtool_set_rxnfc() function.  We need to check for invalid values to
> prevent a buffer overflow.
> 
> I copy and pasted this check from the mvpp2_ethtool_cls_rule_ins()
> function.
> 
> Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classification offload support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.