lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 7 May 2020 10:17:37 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     davem@...emloft.net, Dave Ertman <david.m.ertman@...el.com>,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jgg@...pe.ca,
        ranjani.sridharan@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        Andrew Bowers <andrewx.bowers@...el.com>
Subject: Re: [net-next v3 2/9] ice: Create and register virtual bus for RDMA

On Wed, May 06, 2020 at 02:04:58PM -0700, Jeff Kirsher wrote:
> From: Dave Ertman <david.m.ertman@...el.com>
> 
> The RDMA block does not have its own PCI function, instead it must utilize
> the ice driver to gain access to the PCI device. Create a virtual bus
> device so the irdma driver can register a virtual bus driver to bind to it
> and receive device data. The device data contains all of the relevant
> information that the irdma peer will need to access this PF's IIDC API
> callbacks.

But there is no virtual bus driver in this patch!

What am I missing?  This patch is really really hard to follow, you seem
to be adding new functionality at the same time you are adding virtual
devices, is there some way to split it up into reviewable pieces?  This
feels like a big mix of things all lumped together.

In other words, I can't review this at all to try to see if you are
using the virtual devices properly at all, which is not a good thing...

greg k-h

Powered by blists - more mailing lists