netdev - Re: [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <828ef810-9768-5b5c-7847-0edeb666af9b@solarflare.com>
Date:   Thu, 7 May 2020 11:38:24 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>,
        <netfilter-devel@...r.kernel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <jiri@...nulli.us>, <kuba@...nel.org>
Subject: Re: [PATCH net,v4] net: flow_offload: skip hw stats check for
 FLOW_ACTION_HW_STATS_DONT_CARE

On 06/05/2020 19:34, Pablo Neira Ayuso wrote> -	} else if (act->hw_stats != FLOW_ACTION_HW_STATS_DISABLED) {
> +	} else if (act->hw_stats != FLOW_ACTION_HW_STATS_DISABLED &&
> +		   act->hw_stats != FLOW_ACTION_HW_STATS_DONT_CARE) {
>  		NL_SET_ERR_MSG_MOD(extack, "Unsupported action HW stats type");
>  		return -EOPNOTSUPP;
>  	}
FWIW my whole reason for suggesting DONT_CARE==0 in the first place
 was so that drivers could just use it as a boolean, e.g.
    if (act->hw_stats && !(act->hw_stats & FLOW_ACTION_HW_STATS_BLAH))
        error("driver only supports BLAH stats");
If you're not even doing that then the case for DONT_CARE == ~0 is
 even stronger.
Sorry I wasn't quick enough on the draw to say this before v4 was
 applied (I was waiting for an answer on the v2 thread; posting a
 Nack on v3 felt like it might come across as needlessly combative).

-ed