netdev - Re: net: broadcom: fix a mistake about ioremap resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c33b90a6-3f4d-d3fb-7f65-928247cd2ee7@web.de>
Date:   Thu, 7 May 2020 13:16:29 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Jonathan Richardson <jonathan.richardson@...adcom.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Dejin Zheng <zhengdejin5@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Petr Štetiar <ynezz@...e.cz>,
        Ray Jui <ray.jui@...adcom.com>,
        Scott Branden <scott.branden@...adcom.com>,
        Stephen Boyd <swboyd@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: net: broadcom: fix a mistake about ioremap resource

>> I hope that other contributors can convince you to improve also this
>> commit message considerably.
>> Would you like to fix the spelling besides other wording weaknesses?
>
> How about this wording:
>
> Commit d7a5502b0bb8b ("net: broadcom: convert to
> devm_platform_ioremap_resource_byname()")
> inadvertently made idm_base and nicpm_base mandatory. These are
> optional properties.
> probe will fail when they're not defined. The commit is partially
> reverted so that they are
> obtained by platform_get_resource_byname() as before. amac_base can
> still be obtained
> by devm_platform_ioremap_resource_byname().

Is it interesting anyhow that another attempt for such an improvement
did not get the possibly desired software development attention?
https://lore.kernel.org/lkml/20200505.111206.118627398774406136.davem@davemloft.net/
https://lore.kernel.org/patchwork/comment/1430759/
https://lkml.org/lkml/2020/5/5/1114

Regards,
Markus