netdev - Re: [PATCH net,v4] net: flow_offload: skip hw stats check for FLOW_ACTION_HW_STATS_DONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbe545f3-b041-ffe4-a908-f7e29afa322d@solarflare.com>
Date:   Thu, 7 May 2020 13:15:37 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
CC:     <netfilter-devel@...r.kernel.org>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <jiri@...nulli.us>, <kuba@...nel.org>
Subject: Re: [PATCH net,v4] net: flow_offload: skip hw stats check for
 FLOW_ACTION_HW_STATS_DONT_CARE

On 07/05/2020 12:44, Pablo Neira Ayuso wrote:
> Could you point to what driver might have any problem with this update?
Drivers *can* implement the API in this patch.  It's just that the
 alternative API Jakub proposed would make for simpler driver code.
I.e. I'm not saying it's bad, just that it could be made better.
That's why I didn't hard-NACK it at any point.
I guess I should send the change I'm suggesting as a patch, rather
 than asking it of you — I'll try to get that done today.
(Although I'm not sure if it's really 'net' material or if I should
 wait for David to merge net into net-next and make the patch
 against the latter — wdyt?)

-ed