netdev - Re: [PATCH] tcp: tcp_mark_head_lost is only valid for sack-tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQym+O5tgCyRO+MJopXzwcxsGGkCpTpdX648fTsAjMZO3Gw@mail.gmail.com>
Date:   Thu, 7 May 2020 09:58:30 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     zhang kai <zhangkaiheb@....com>
Cc:     Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] tcp: tcp_mark_head_lost is only valid for sack-tcp

On Wed, May 6, 2020 at 11:09 PM zhang kai <zhangkaiheb@....com> wrote:
>
> so tcp_is_sack/reno checks are removed from tcp_mark_head_lost.
>
> Signed-off-by: zhang kai <zhangkaiheb@....com>
> ---

Nice clean-up, thanks.

Acked-by: Neal Cardwell <ncardwell@...gle.com>

As Eric noted in previous threads, this clean-up is now possible after:

6ac06ecd3a5d1dd1aaea5c2a8f6d6e4c81d5de6a ("tcp: simpler NewReno implementation")

As Yuchung noted, the tcp_mark_head_lost() function is not used today
when RACK is enabled (which is by
default).

neal