netdev - Re: [PATCH] net: remove spurious declaration of tcp_default_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e307670-79b2-3a8e-65b1-09be046a638b@gmail.com>
Date:   Thu, 7 May 2020 07:10:05 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>,
        Maciej Żenczykowski <maze@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Linux Network Development Mailing List <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: remove spurious declaration of
 tcp_default_init_rwnd()



On 5/7/20 12:58 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> it doesn't actually exist...
> 
> Test: builds and 'git grep tcp_default_init_rwnd' comes up empty
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  include/net/tcp.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/net/tcp.h b/include/net/tcp.h
> index dcf9a72eeaa6..64f84683feae 100644
> --- a/include/net/tcp.h
> +++ b/include/net/tcp.h
> @@ -1376,7 +1376,6 @@ static inline void tcp_sack_reset(struct tcp_options_received *rx_opt)
>  	rx_opt->num_sacks = 0;
>  }
>  
> -u32 tcp_default_init_rwnd(u32 mss);
>  void tcp_cwnd_restart(struct sock *sk, s32 delta);
>  
>  static inline void tcp_slow_start_after_idle_check(struct sock *sk)
> 

Right, we should have removed this at the time commit a337531b942b
 ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB") went in.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Thanks !