netdev - Re: [RFC PATCH net] net: flow_offload: simplify hw stats check handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200507153231.GA10250@salvia>
Date:   Thu, 7 May 2020 17:32:31 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        netfilter-devel@...r.kernel.org, jiri@...nulli.us, kuba@...nel.org
Subject: Re: [RFC PATCH net] net: flow_offload: simplify hw stats check
 handling

On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote:
> Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that
>  drivers and __flow_action_hw_stats_check can use simple bitwise checks.

You have have to explain why this makes sense in terms of semantics.

_DISABLED and _ANY are contradicting each other.

> In mlxsw we check for DISABLED first, because we'd rather save the counter
>  resources in the DONT_CARE case.

And this also is breaking netfilter again.

> Signed-off-by: Edward Cree <ecree@...arflare.com>
> ---
> Compile tested only.
> 
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 8 ++++----
>  include/net/flow_offload.h                            | 8 ++++----

Turning DONT_CARE gives us nothing back at all.